gtristan commented on code in PR #1746:
URL: https://github.com/apache/buildstream/pull/1746#discussion_r960635674
##########
src/buildstream/_platform/platform.py:
##########
@@ -44,16 +44,16 @@ def _setup_sandbox(self):
# Try to setup buildbox-run sandbox, otherwise fallback to the dummy
sandbox.
try:
self._check_sandbox(SandboxBuildBoxRun)
- except (SandboxError, utils.ProgramNotFoundError):
+ except (SandboxUnsupportedError, utils.ProgramNotFoundError):
pass
def _check_sandbox(self, Sandbox):
Sandbox._dummy_reasons = []
try:
Sandbox.check_available()
- except SandboxError as Error:
+ except SandboxUnsupportedError as Error:
Review Comment:
It should be made private generally, so as not to take up any public
namespace (In this instance it’s not very important given that the user does
not subclass sandboxes).
One underscore for shared internal API, two underscores for module internal
details (two underscores are only used in these public facing classes, where
the distinction between “private” and “internal” is significant).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
