nanonyme commented on code in PR #1763: URL: https://github.com/apache/buildstream/pull/1763#discussion_r982704054
########## requirements/requirements.txt: ########## @@ -1,15 +1,13 @@ click==8.1.3 grpcio==1.46.0 -Jinja2==3.1.2 +jinja2==3.1.2 +markupsafe==2.1.1 pluginbase==1.0.1 -protobuf==3.20.1 +protobuf==3.20.2 psutil==5.9.0 -ruamel.yaml==0.17.21 -ruamel.yaml.clib==0.2.6 -setuptools==44.1.1 Review Comment: Actually maybe this doesn't belong here anyway. But instead https://github.com/apache/buildstream/blob/master/pyproject.toml#L4 should declare version range of setuptools this package needs to build. So when build isolation is used, pip will just fetch compatible setuptools and use it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
