cs-shadow commented on code in PR #1763:
URL: https://github.com/apache/buildstream/pull/1763#discussion_r1059110213
##########
requirements/requirements.txt:
##########
@@ -1,15 +1,13 @@
click==8.1.3
grpcio==1.46.0
-Jinja2==3.1.2
+jinja2==3.1.2
+markupsafe==2.1.1
pluginbase==1.0.1
-protobuf==3.20.1
+protobuf==3.20.2
psutil==5.9.0
-ruamel.yaml==0.17.21
-ruamel.yaml.clib==0.2.6
-setuptools==44.1.1
Review Comment:
we'd actually need `importlib.metadata` here that has is only in the
standard library 3.8 onwards. There's a pypi package named `importlib_metadata`
though which we can use. But i think swapping the setuptools dependency in
favor of `importlib_metadata` won't be a bad idea, even if it'll lead to a
try-except like:
```python
try:
import importlib.metadata as importlib_metadata
except ImportError:
import importlib_metadata
...
importlib_metadata.do_something()
```
##########
requirements/requirements.txt:
##########
@@ -1,15 +1,13 @@
click==8.1.3
grpcio==1.46.0
-Jinja2==3.1.2
+jinja2==3.1.2
+markupsafe==2.1.1
pluginbase==1.0.1
-protobuf==3.20.1
+protobuf==3.20.2
psutil==5.9.0
-ruamel.yaml==0.17.21
-ruamel.yaml.clib==0.2.6
-setuptools==44.1.1
Review Comment:
we'd actually need `importlib.metadata` here that is only in the standard
library 3.8 onwards. There's a pypi package named `importlib_metadata` though
which we can use. But i think swapping the setuptools dependency in favor of
`importlib_metadata` won't be a bad idea, even if it'll lead to a try-except
like:
```python
try:
import importlib.metadata as importlib_metadata
except ImportError:
import importlib_metadata
...
importlib_metadata.do_something()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
