gtristan commented on code in PR #39:
URL: 
https://github.com/apache/buildstream-plugins/pull/39#discussion_r1038811215


##########
src/buildstream_plugins/elements/autotools.yaml:
##########
@@ -31,9 +31,6 @@ variables:
   # Element-specific extra arguments to be passed to `configure`.
   conf-local: ''
 
-  # For backwards compatibility only, do not use.
-  conf-extra: ''
-
   conf-cmd: "%{conf-root}/configure"
   
   conf-args: |

Review Comment:
   I’d be happy if the backslashes went away, but they are required to split 
lines in shell scripts.
   
   I’m sure that if we thought it were more legible to read all on a single 
line wrapping around the terminal, then we would also write it all in one line 
in the YAML file.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to