gtristan commented on code in PR #39:
URL:
https://github.com/apache/buildstream-plugins/pull/39#discussion_r1038868174
##########
src/buildstream_plugins/elements/autotools.yaml:
##########
@@ -31,9 +31,6 @@ variables:
# Element-specific extra arguments to be passed to `configure`.
conf-local: ''
- # For backwards compatibility only, do not use.
- conf-extra: ''
-
conf-cmd: "%{conf-root}/configure"
conf-args: |
Review Comment:
Reading the build log and observing precisely how a module is configured
will be always be important (for example when wondering why your system doesn’t
behave quite how you expected it to), so having the logs be as human readable
as possible is very important.
The subjective prettiness of the YAML file itself cannot be as important as
this, and anyway, it will never be edited again, so there is no reason to look
at it.
Except when displaying the defaults in documentation, where again, it is a
good idea to show good practice of using the backslashes, because they have
actual practical value in rendering more clear and readable logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
