abderrahim commented on code in PR #1903:
URL: https://github.com/apache/buildstream/pull/1903#discussion_r1539659142
##########
src/buildstream/sourcemirror.py:
##########
@@ -93,6 +93,13 @@ class SourceMirror(Plugin):
# The SourceMirror plugin type is only supported since BuildStream 2.2
BST_MIN_VERSION = "2.2"
+ COMMON_CONFIG_KEYS = ["name", "kind"]
Review Comment:
The main reason I did this is to be able to implement the "legacy" plugin as
a regular plugin (so that it can have `aliases` in the main dictionary). I have
since added some special casing to it, but I'm still not sure how this could be
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
