gtristan commented on code in PR #1903:
URL: https://github.com/apache/buildstream/pull/1903#discussion_r1545459135
##########
src/buildstream/sourcemirror.py:
##########
@@ -93,6 +93,13 @@ class SourceMirror(Plugin):
# The SourceMirror plugin type is only supported since BuildStream 2.2
BST_MIN_VERSION = "2.2"
+ COMMON_CONFIG_KEYS = ["name", "kind"]
Review Comment:
I would say:
* Don't expose `COMMON_CONFIG_KEYS` as public API
* Keep `"aliases"` as a special/different configuration for the default
SourceMirror type
* Don't allow other/user implemented `SourceMirror` plugins to extend
configuration in the main `mirror` namespace (only under `config`)
I'd be happy if the base class simply made a special case for the
`"default"` SourceMirror plugin type, passing it the `node` directly to
`self._configure()` rather than passing the `config` dictionary for every other
case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
