gtristan commented on code in PR #1907:
URL: https://github.com/apache/buildstream/pull/1907#discussion_r1549664820
##########
src/buildstream/_frontend/app.py:
##########
@@ -909,13 +905,10 @@ def _assert_element_path(self, element_path):
# min_version (int): The user selected minimum BuildStream version
# element_path (str): The user selected element path
#
- def _init_project_interactive(self, project_name, min_version=None,
element_path="elements"):
+ def _init_project_interactive(self, project_name, min_version,
element_path):
bst_major, bst_minor = utils._get_bst_api_version()
- if min_version is None:
Review Comment:
This will make the `"default"` to `click.prompt()` be `None` at all times.
I think we should keep providing the default as the currently installed
BuildStream version, as `click.prompt()` probably uses this to show the user
what the default selection will be if they press ENTER without any value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
