abderrahim commented on code in PR #1907:
URL: https://github.com/apache/buildstream/pull/1907#discussion_r1549675037
##########
src/buildstream/_frontend/app.py:
##########
@@ -909,13 +905,10 @@ def _assert_element_path(self, element_path):
# min_version (int): The user selected minimum BuildStream version
# element_path (str): The user selected element path
#
- def _init_project_interactive(self, project_name, min_version=None,
element_path="elements"):
+ def _init_project_interactive(self, project_name, min_version,
element_path):
bst_major, bst_minor = utils._get_bst_api_version()
- if min_version is None:
Review Comment:
It doesn't. The real default is hardcoded at
https://github.com/apache/buildstream/blob/master/src/buildstream/_frontend/cli.py#L411.
It is never `None` here.
Another thing we can do is to drop the hardcoded default above, and
initialize it here if it is `None`. The downside of that would be that `bst
init --help` will no longer show the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
