nanonyme commented on code in PR #62: URL: https://github.com/apache/buildstream-plugins/pull/62#discussion_r1574354753
########## src/buildstream_plugins/sources/cargo.py: ########## @@ -75,6 +85,10 @@ from buildstream import Source, SourceFetcher, SourceError from buildstream import utils +import dulwich Review Comment: The bigger problem to be honest is lack of tests with the plugins involved. Even if minimum version is set (like it is now), nothing proves it actually works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
