gtristan commented on code in PR #62: URL: https://github.com/apache/buildstream-plugins/pull/62#discussion_r1585903820
########## src/buildstream_plugins/sources/cargo.py: ########## @@ -75,6 +85,10 @@ from buildstream import Source, SourceFetcher, SourceError from buildstream import utils +import dulwich Review Comment: The experimental repo is indeed the wild west, no objections to that. The issue is that even with python libraries which conform well to pythonic standards of API compatibility, and follow semantic versioning, are not strict enough to be safe to use in a BuildStream plugin strictly speaking, since it is impossible to address both API versions separately (import names have not changed) or install both versions in a single python environment. This will be equally true of course for the `bst-plugins-experimental` plugins, but we are not concerned with long term compatibility there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
