nanonyme commented on code in PR #1754:
URL: https://github.com/apache/buildstream/pull/1754#discussion_r1901863496
##########
src/buildstream/utils.py:
##########
@@ -1260,14 +1254,7 @@ def _call(*popenargs, terminate=False, **kwargs):
process = None
- old_preexec_fn = kwargs.get("preexec_fn")
Review Comment:
@juergbi I'm not 100% sure if this should logically be like this or
`kwargs.setdefault("umask"], stat.S_IWGRP | stat.S_IWOTH)`. Is it expected
caller can override umask?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
