juergbi commented on code in PR #1754:
URL: https://github.com/apache/buildstream/pull/1754#discussion_r1910193420
##########
src/buildstream/utils.py:
##########
@@ -1260,14 +1254,7 @@ def _call(*popenargs, terminate=False, **kwargs):
process = None
- old_preexec_fn = kwargs.get("preexec_fn")
Review Comment:
We don't allow plugins to set `preexec_fn` or `umask`, so it wouldn't make a
difference right now. However, the point of this umask is to make sure that the
umask is deterministic. It's not completely unreasonable to allow plugins to
choose a different umask. So I think changing it to `setdefault()` would make
sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
