joshua-zivkovic commented on code in PR #2095:
URL: https://github.com/apache/buildstream/pull/2095#discussion_r2555254423
##########
src/buildstream/source.py:
##########
@@ -572,6 +579,31 @@ def __init__(
The url of the source input
"""
+ self.attribution_text: Optional[str] = attribution_text
+ """
+ Required acknowledgements for the package
Review Comment:
SPDX has it's own idea of what a package is, from the docs:
"A package refers to any unit of content that can be associated with a
distribution of software. Typically, a package is composed of one or more
files. An SPDX document may, but is not required to, provide details about the
individual files comprising a package".
Given, I believe, any information that would be stored in this field would
also need to be in the license or copyright anyway, there is no harm in
omitting this field.
We could use a different field for such information but, as you said, it
can't be mapped to SPDX so I'm not sure on the overall value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
