joshua-zivkovic commented on PR #2095: URL: https://github.com/apache/buildstream/pull/2095#issuecomment-3646088232
From a brief chat with @juergbi, this can and should be done in a more generic way; skipping the hardcoded definitions of specific SPDX attributes. The buildstream core does not need to care about these attributes so instead this should be implemented such that: - the specific attributes a project cares about are stored in the `project.conf` - we use an external SPDX library for these types and offload the storage of attributes to that and buildstream only processes them all as generically as possible. This removes the blocker of us only supporting the attributes we think users would need as well as maintaining them ourselves in both cases. Thinking a few steps ahead on this too though, using only the `project.conf` makes giving plugins the ability to auto populate some of these fields more difficult since there's no predetermined agreed attribute to operate on in the code. The second option alleviates this by at least letting us suitably validate project defined SPDX attributes against the schema and keep everything on the same page that way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
