wsalmonct commented on code in PR #2153: URL: https://github.com/apache/buildstream/pull/2153#discussion_r3703066593
########## src/buildstream/_pipeline.py: ########## @@ -44,7 +44,7 @@ # Yields: # Elements in the scope of the specified target elements # -def dependencies(targets: List[Element], scope: int, *, recurse: bool = True) -> Iterator[Element]: +def dependencies(targets: List[Element], scope: _Scope, *, recurse: bool = True) -> Iterator[Element]: Review Comment: It strikes me as odd to have private API (enum) in a public API (function), technically this is in a private module, eg _pipeline but the class might be placed into public API else were, eg at a higher level module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
