juergbi commented on code in PR #2153: URL: https://github.com/apache/buildstream/pull/2153#discussion_r3703197899
########## src/buildstream/_pipeline.py: ########## @@ -44,7 +44,7 @@ # Yields: # Elements in the scope of the specified target elements # -def dependencies(targets: List[Element], scope: int, *, recurse: bool = True) -> Iterator[Element]: +def dependencies(targets: List[Element], scope: _Scope, *, recurse: bool = True) -> Iterator[Element]: Review Comment: Placing `_pipeline` into public API would violate our public API rules. I.e., this is an internal function and `_Scope` is an internal type. It may look odd but it follows our rules and shouldn't be exposed anywhere in the public API, so I don't see an issue. Marking this as resolved but if you see a real issue or have a suggestion for improvement, feel free to reopen it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
