juergbi commented on code in PR #2104:
URL: https://github.com/apache/buildstream/pull/2104#discussion_r3712186832


##########
src/buildstream/_stream.py:
##########
@@ -1816,6 +1816,7 @@ def _add_queue(self, queue, *, track=False):
         if not track and not self.queues:
             # First non-track queue
             queue.set_required_element_check()
+            queue.set_session_elements(self.session_elements)

Review Comment:
   This is never executed for `bst source track`, resulting in the frontend 
indicating 0 session elements.
   
   `query_cache` marks the `CacheQueryQueue` (with `storage-service`) also as 
`track=True`. Need to make sure that fixing `bst source track` won't make the 
counter wrong in sessions with a `CacheQueryQueue`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to