juergbi commented on code in PR #2104:
URL: https://github.com/apache/buildstream/pull/2104#discussion_r3712200223
##########
src/buildstream/_scheduler/queues/queue.py:
##########
@@ -381,6 +393,9 @@ def _element_log_path(self, element):
# element (Element): The Element to enqueue
#
def _enqueue_element(self, element):
+ if self.session_elements is not None:
+ self.session_elements.append(element)
Review Comment:
`_enqueue_element` seems to be called also for retried jobs. I haven't
tested it but this might increase the counter too much. Maybe
`session_elements` should be a set instead? (May need to use `OrderedDict` as
the order may be significant).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
