c1assik commented on code in PR #2174:
URL: https://github.com/apache/buildstream/pull/2174#discussion_r3797548176
##########
src/buildstream/_stream.py:
##########
@@ -844,7 +844,8 @@ def artifact_log(self, targets):
self._context.messenger.warn("{} is cached without log
files".format(ref))
continue
- artifact_logs[obj.name] = obj._get_logs()
+ name = ref if isinstance(obj, ArtifactElement) else
obj._get_full_name()
Review Comment:
Added a method _get_full_name() to ArtifactElement.
return self.get_artifact_name(), unconditionally fails with`
AssertionError: assert key is not None` in get_artifact_name() so if the cache
key isn't set yet, fall back to super()._get_full_name() (the base
Plugin/Element name, which is always safe since it's precomputed earlier in
Plugin.__init__). Once construction finishes and the key is set, it returns the
full artifact ref as intended
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
