Thanatos9404 opened a new pull request, #2212: URL: https://github.com/apache/buildstream/pull/2212
A script element with a relative cwd, like the `cwd: elements` in the issue, loads fine and then trips the assertion in `Sandbox.set_work_directory()` during the build, which shows up as a BUG with a traceback. A relative build-root or install-root on a build element, or a relative install root on a script element, fails the same way in `mark_directory()`. ScriptElement and BuildElement now check these directories in `preflight()`, after variables are resolved, and raise an ElementError, so `bst show` and `bst build` report the element and the path before any job starts. The sandbox assertions stay as they are. I added tests in tests/format/variables.py and ran the format, frontend and related test modules, plus black, pylint and mypy, locally. Fixes #2077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
