zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the
JSON_LENGTH function
URL: https://github.com/apache/calcite/pull/1070#discussion_r262378331
##########
File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java
##########
@@ -322,27 +322,20 @@ private RexNode simplifyComparison(RexCall e,
RexUnknownAs unknownAs) {
// Simplify "x <op> x"
final RexNode o0 = operands.get(0);
final RexNode o1 = operands.get(1);
- if (o0.equals(o1)) {
- RexNode newExpr;
+ if (o0.equals(o1)
Review comment:
It seems that following changes revert the commit
https://github.com/apache/calcite/commit/d10aeb7f7e50dc7028ce102a5f590d0c50c49fa8,
I guess they are by mistake?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
