zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the
JSON_LENGTH function
URL: https://github.com/apache/calcite/pull/1070#discussion_r262381729
##########
File path: core/src/test/java/org/apache/calcite/test/RexProgramTest.java
##########
@@ -1223,37 +1223,37 @@ private void checkExponentialCnf(int n) {
// "x = x" simplifies to "x is not null"
checkSimplify(eq(literal1, literal1), "true");
checkSimplify(eq(hRef, hRef), "true");
- checkSimplify3(eq(iRef, iRef), "OR(null, IS NOT NULL(?0.i))", "IS NOT
NULL(?0.i)", "true");
+ checkSimplify2(eq(iRef, iRef), "=(?0.i, ?0.i)", "IS NOT NULL(?0.i)");
Review comment:
Same issue with the changes to RexSimplify.java.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
