xndai commented on a change in pull request #1099: [CALCITE-2908] Implement SQL 
LAST_DAY function
URL: https://github.com/apache/calcite/pull/1099#discussion_r264335059
 
 

 ##########
 File path: 
core/src/test/java/org/apache/calcite/sql/test/SqlOperatorBaseTest.java
 ##########
 @@ -5577,6 +5577,46 @@ private void checkNullOperand(SqlTester tester, String 
op) {
     }
   }
 
+  @Test public void testLastDayFunc() {
 
 Review comment:
   do you need an end to end test to verify this new function in a SQL query?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to