xndai commented on a change in pull request #1099: [CALCITE-2908] Implement SQL
LAST_DAY function
URL: https://github.com/apache/calcite/pull/1099#discussion_r264331205
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
##########
@@ -373,6 +374,8 @@ public Expression implement(RexToLixTranslator translator,
BuiltInMethod.UNIX_TIMESTAMP_CEIL.method,
BuiltInMethod.UNIX_DATE_CEIL.method), false);
+ defineMethod(LAST_DAY, "lastDay", NullPolicy.STRICT);
Review comment:
"lastday"? I see all the current method names are lower case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
