julianhyde commented on a change in pull request #1102: [CALCITE-1515]
RelBuilder supports creating TableFunctionScan
URL: https://github.com/apache/calcite/pull/1102#discussion_r265400405
##########
File path: core/src/main/java/org/apache/calcite/rel/core/RelFactories.java
##########
@@ -549,6 +555,34 @@ public RelNode createMatch(RelNode input, RexNode pattern,
partitionKeys, orderKeys, interval);
}
}
+
+ /**
+ * Can create a {@link TableFunctionScan}
+ * of the appropriate type for a rule's calling convention.
+ */
+ public interface TableFunctionScanFactory {
+ /** Creates a {@link TableFunctionScan}. */
+ RelNode createTableFunctionScan(RelOptCluster cluster,
+ List<RelNode> inputs, RexNode rexCall, Type elementType,
Review comment:
I don't think there should be an `inputs` parameter. You should pass 'int
inputCount', and it will pop the right number of RelNodes off of the stack. See
`union`, another relational operator that takes a variable number of inputs.
This impacts the `cursor` method. See my comments there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
