julianhyde commented on a change in pull request #1102: [CALCITE-1515]
RelBuilder supports creating TableFunctionScan
URL: https://github.com/apache/calcite/pull/1102#discussion_r265400507
##########
File path:
core/src/main/java/org/apache/calcite/rel/core/TableFunctionScan.java
##########
@@ -64,6 +64,7 @@
*
* @param cluster Cluster that this relational expression belongs to
* @param inputs 0 or more relational inputs
+ * @param traits Traits
Review comment:
Can you rename this parameter to `traitSet`. That is the preferred name
these days. Thanks for adding javadoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
