zhztheplayer commented on a change in pull request #1070: [CALCITE-2808]Add the 
JSON_LENGTH function
URL: https://github.com/apache/calcite/pull/1070#discussion_r265861435
 
 

 ##########
 File path: 
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
 ##########
 @@ -3096,6 +3096,13 @@ private void checkLiteral2(String expression, String 
expected) {
     sql(query).ok(expected);
   }
 
+  @Test public void testJsonLength() {
+    String query = "select json_length(\"product_name\", 'lax $') from 
\"product\"";
 
 Review comment:
   I think it's better to add another case for the syntax `json_length(value)`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to