leesf commented on a change in pull request #88: [hotfix] fix typo in
AbstractService
URL: https://github.com/apache/calcite-avatica/pull/88#discussion_r268955708
##########
File path:
core/src/main/java/org/apache/calcite/avatica/remote/AbstractService.java
##########
@@ -89,7 +89,7 @@ ColumnMetaData finagle(ColumnMetaData column) {
case PROTOBUF:
return column;
default:
Review comment:
I agree with julian. Since in Java switch default + exception is very usual
in practice, and we just need to give right info in exception stack.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
