hsyuan commented on a change in pull request #1141: [CALCITE-2914] Improve how
LatticeSuggester deduces foreign keys
URL: https://github.com/apache/calcite/pull/1141#discussion_r270691745
##########
File path: core/src/main/codegen/templates/Parser.jj
##########
@@ -5652,6 +5652,24 @@ SqlCall withinGroup(SqlNode arg) :
}
}
+SqlCall nullTreatment(SqlCall arg) :
+{
+ final Span span;
+}
+{
+ (
+ <IGNORE> { span = span(); } <NULLS> {
+ return SqlStdOperatorTable.IGNORE_NULLS.createCall(
+ span.end(this), arg);
+ }
+ |
+ <RESPECT> { span = span(); } <NULLS> {
+ return SqlStdOperatorTable.RESPECT_NULLS.createCall(
+ span.end(this), arg);
+ }
+ )
+}
+
Review comment:
Isn't this part (RESPECT/IGNORE NULLS) already in master by commit:
https://github.com/apache/calcite/commit/d7946a94adfd2e788f5d324910944dd65dab11ee
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
