chunweilei commented on a change in pull request #1141: [CALCITE-2914] Improve
how LatticeSuggester deduces foreign keys
URL: https://github.com/apache/calcite/pull/1141#discussion_r270698337
##########
File path: core/src/main/codegen/templates/Parser.jj
##########
@@ -5652,6 +5652,24 @@ SqlCall withinGroup(SqlNode arg) :
}
}
+SqlCall nullTreatment(SqlCall arg) :
+{
+ final Span span;
+}
+{
+ (
+ <IGNORE> { span = span(); } <NULLS> {
+ return SqlStdOperatorTable.IGNORE_NULLS.createCall(
+ span.end(this), arg);
+ }
+ |
+ <RESPECT> { span = span(); } <NULLS> {
+ return SqlStdOperatorTable.RESPECT_NULLS.createCall(
+ span.end(this), arg);
+ }
+ )
+}
+
Review comment:
There are 3 commits in this PR. It looks like the first commit
[0c0e90](https://github.com/apache/calcite/pull/1141/commits/0c0e908b64949095af1c9c21815880089f52c34f)
is the very commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
