zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow
MultiJoin rules with any project/filter
URL: https://github.com/apache/calcite/pull/1030#discussion_r271079033
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/FilterMultiJoinMergeRule.java
##########
@@ -43,7 +44,9 @@
//~ Constructors -----------------------------------------------------------
/**
- * Creates a FilterMultiJoinMergeRule.
+ * Creates a FilterMultiJoinMergeRule that uses {@link Filter}
+ * of type {@link LogicalFilter}
+ * @param relBuilderFactory builder factory for relational expressions
*/
public FilterMultiJoinMergeRule(RelBuilderFactory relBuilderFactory) {
super(
Review comment:
I think it is better to use the telescoping constructor pattern here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
