zabetak commented on a change in pull request #1030: [CALCITE-2822] Allow
MultiJoin rules with any project/filter
URL: https://github.com/apache/calcite/pull/1030#discussion_r271510854
##########
File path: core/src/main/java/org/apache/calcite/rel/core/RelFactories.java
##########
@@ -295,6 +296,10 @@ public RelNode createAggregate(RelNode input, boolean
indicator,
public interface FilterFactory {
/** Creates a filter. */
RelNode createFilter(RelNode input, RexNode condition);
+
+ /** Creates a filter */
+ RelNode createFilter(RelNode input, RexNode condition,
Review comment:
Adding new methods in interfaces also breaks backward compatibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
