zhztheplayer commented on a change in pull request #1146: [CALCITE-2975] Add 
the JSON_REMOVE function
URL: https://github.com/apache/calcite/pull/1146#discussion_r273929840
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/runtime/CalciteResource.java
 ##########
 @@ -882,6 +882,9 @@
 
   @BaseMessage("Not a valid input for JSON_KEYS: ''{0}''")
   ExInst<CalciteException> invalidInputForJsonKeys(String value);
+
+  @BaseMessage("Remove json error for JSON_REMOVE: jsonDoc: ''{0}'', 
jsonPaths: ''{1}''")
 
 Review comment:
   The message is not much clear, could you please improve it? Maybe keeping it 
consistent with the others is enough. E.g.
   ```
   Invalid input for JSON_REMOVE: jsonDoc: ''{0}'', jsonPaths: ''{1}''
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to