zhztheplayer commented on a change in pull request #1146: [CALCITE-2975] Add
the JSON_REMOVE function
URL: https://github.com/apache/calcite/pull/1146#discussion_r274247375
##########
File path: core/src/test/java/org/apache/calcite/test/SqlJsonFunctionsTest.java
##########
@@ -533,6 +533,13 @@ public void testJsonKeys() {
is("null"));
}
+ @Test
+ public void testJsonRemove() {
+ assertJsonRemove(is("{\"b\":[2]}"),
+ SqlFunctions.dejsonize("{\"a\": 1, \"b\": [2]}"),
Review comment:
And maybe we can add something like the `SqlTester#setFor()` method (see
below) for both `SqlFunctuionsTest` and `SqlJsonFunctionsTest` for generating
readable messages, so that we can remove these `assertXXX` methods.
https://github.com/apache/calcite/blob/72e952d1a79ee2d7ba05de88cbc2ac11f65cd879/core/src/test/java/org/apache/calcite/sql/test/SqlTester.java#L298-L300
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
