danny0405 commented on a change in pull request #85: [CALCITE-2704] Avoid use
of ISO-8859-1 to parse request in JsonHandler
URL: https://github.com/apache/calcite-avatica/pull/85#discussion_r274873379
##########
File path:
server/src/main/java/org/apache/calcite/avatica/server/AvaticaJsonHandler.java
##########
@@ -106,14 +106,18 @@ public void handle(String target, Request baseRequest,
// Avoid a new buffer creation for every HTTP request
final UnsynchronizedBuffer buffer = threadLocalBuffer.get();
try (ServletInputStream inputStream = request.getInputStream()) {
- rawRequest = AvaticaUtils.readFully(inputStream, buffer);
+ byte[] bytes = AvaticaUtils.readFullyToBytes(inputStream, buffer);
+ String encoding = request.getCharacterEncoding();
+ if (encoding == null) {
+ encoding = "UTF-8";
Review comment:
+1 for StandardCharsets.UTF_8, i think the default UTF8 is okey, cause UTF8
is the most popular encoding for Internet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
