jcamachor commented on a change in pull request #1171: [CALCITE-3011] Support
for joins with AggregateJoinTransposeRule
URL: https://github.com/apache/calcite/pull/1171#discussion_r277764298
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/AggregateJoinTransposeRule.java
##########
@@ -336,8 +346,9 @@ public void onMatch(RelOptRuleCall call) {
relBuilder.project(projects);
boolean aggConvertedToProjects = false;
- if (allColumnsInAggregate) {
+ if (allColumnsInAggregate && join.getJoinType() != JoinRelType.FULL) {
Review comment:
`&& join.getJoinType() != JoinRelType.FULL) {` is not needed anymore if we
bail out correctly above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
