jcamachor commented on a change in pull request #1171: [CALCITE-3011] Support
for joins with AggregateJoinTransposeRule
URL: https://github.com/apache/calcite/pull/1171#discussion_r277763481
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/AggregateJoinTransposeRule.java
##########
@@ -146,12 +146,22 @@ private static boolean isAggregateSupported(Aggregate
aggregate, boolean allowFu
return true;
}
+ // OUTER joins are supported for group by without aggregate functions
+ private boolean isJoinSupported(final Join join, final Aggregate aggregate) {
+ return join.getJoinType() != JoinRelType.FULL
Review comment:
`&&` has higher precedence than `||`, hence this will not avoid execution of
this rule for FULL OUTER joins in all cases. This should be rewritten to:
```
return join.getJoinType() == JoinRelType.INNER ||
aggregate.getAggCallList().isEmpty() && join.getJoinType() !=
JoinRelType.FULL;
```
Please update comment above to describe why full outer join is not supported.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
