danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r279149384
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableHashJoin.java
##########
@@ -161,31 +142,48 @@ public static EnumerableJoin create(
} else {
rowCount += rightRowCount;
}
- return planner.getCostFactory().makeCost(rowCount, 0, 0);
+ if (isNonCorrelatedSemiJoin()) {
+ return planner.getCostFactory().makeCost(rowCount, 0,
0).multiplyBy(.01d);
Review comment:
I don't know the implementation details either, just copy it from
EnumerableSemiJoin, the oldest commit about it is 2014 and seems just a code
refactor, so i just keep it as before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
