danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r279226373
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableHashJoin.java
##########
@@ -161,31 +142,48 @@ public static EnumerableJoin create(
} else {
rowCount += rightRowCount;
}
- return planner.getCostFactory().makeCost(rowCount, 0, 0);
+ if (isNonCorrelatedSemiJoin()) {
Review comment:
If this is true, i think we can remove the variables set check and just use
analyzeCondition().getJoinType == JoinRelType.SEMI is enough
I will also have to add a assert in the Join constructor to check that we
don't allow SEMI join type + variablesSet.nonEmpty
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
