rubenada commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r279304920
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableThetaJoin.java
##########
@@ -45,6 +46,7 @@
/** Implementation of {@link org.apache.calcite.rel.core.Join} in
* {@link org.apache.calcite.adapter.enumerable.EnumerableConvention
enumerable calling convention}
* that allows conditions that are not just {@code =} (equals). */
+@Deprecated // to be removed before 2.0
Review comment:
I think merging EnumerableCorrelate (which uses
EnumerableDefaults#correlateJoin) and EnunmerableThetaJoin (which uses
EnumerableDefaults#thetaJoin) into the same EnumerableNestedLoopJoin would
result in a single, but complicated class.
I agree with @hsuanyi (and [this
comment](https://issues.apache.org/jira/browse/CALCITE-2969?focusedCommentId=16827538&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16827538)),
I think it would be simpler to keep EnumerableCorrelate unchanged (so that it
will be clear that it is the Enumerable implementation of Correlate), and
rename only EnumerableThetaJoin as EnumerableNestedLoopJoin.
Having said that, I'll agree with the option chosen by the majority.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
