rubenada commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r279641751
##########
File path: core/src/main/java/org/apache/calcite/rel/core/Correlate.java
##########
@@ -90,13 +90,24 @@ protected Correlate(
RelNode left,
RelNode right,
CorrelationId correlationId,
- ImmutableBitSet requiredColumns, SemiJoinType joinType) {
+ ImmutableBitSet requiredColumns,
+ JoinRelType joinType) {
Review comment:
Correlate must have as joinType one of INNER, LEFT, SEMI, ANTI (i.e the
formerly SemiJoinTypes), I think we should probably throw an
IllegalArgumentException if joinType is not one of those
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
