danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve 
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r283692183
 
 

 ##########
 File path: 
core/src/main/java/org/apache/calcite/rel/metadata/RelMdPredicates.java
 ##########
 @@ -578,6 +577,7 @@ public RelOptPredicateList inferPredicates(
       final Set<RexNode> allExprs = new HashSet<>(this.allExprs);
       final JoinRelType joinType = joinRel.getJoinType();
       switch (joinType) {
+      case SEMI:
 
 Review comment:
   I'm not that sure, i add some `ANTI`s where `SEMI`s appears which i'm 
confident that the modification is right, for the others, i would rather leave 
it to the one who implements the `ANTI` join expression.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to