danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r285152631
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/SemiJoinProjectTransposeRule.java
##########
@@ -63,42 +63,35 @@
*/
private SemiJoinProjectTransposeRule(RelBuilderFactory relBuilderFactory) {
super(
- operand(SemiJoin.class,
+ operandJ(LogicalJoin.class, null, Join::isSemiJoin,
Review comment:
You are right, but the rule's implementation all match `LogicalJoin` instead
of `SemiJoin`, we may need 2 implementations if we want to match `SemiJoin`
class. But how can i fix this ? I thought of a way, rename a new Rule class
which keep the old logic and make this Rule#Instance reference the old one, but
do we really need this ? how about put them in the breaking changes and notes
that this rule's match logic has changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
