rubenada commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r283693065
##########
File path: core/src/main/java/org/apache/calcite/rel/core/Join.java
##########
@@ -230,6 +237,15 @@ public boolean isSemiJoinDone() {
return false;
}
+ /**
+ * Returns whether this Join is a semijoin.
+ *
+ * @return true if this is semi but without correlate variables.
+ */
+ public boolean isSemiJoin() {
Review comment:
Maybe it is convenient to have `isSemiJoin` and `isAntiJoin` auxiliary
methods for some scenarios (although I tend to agree with @zabetak about why
not having them for the rest of join types); but in same cases (e.g. rowType
computation) the logic will be the same for both SEMI and ANTI, so in those
cases I think it would be useful to have a single method (e.g.
returnsJustFirstInput()) rather than calling `isSemiJoin() || isAntiJoin()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
