rubenada commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r287824895
##########
File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java
##########
@@ -3734,6 +3739,12 @@ private Exists(RelNode r, boolean indicator, boolean
outerJoin) {
this.outerJoin = outerJoin;
}
}
+
+ /** Check if it is the join whose condition is based on column equality,
+ * this mostly depends on the physical implementation of the join. */
+ public static boolean forceEquiJoin(Join join) {
+ return join.isSemiJoin() || join instanceof EquiJoin;
Review comment:
I agree with @hsyuan , with the current PR we should start supporting
non-equi semi joins. As defined in EnumerableJoinRule:
- Equi semi joins will run via EnumerableHashJoin (implementHashSemiJoin)
- Non-equi semi joins will run via EnumerableNestedLoopJoin (but I think
this would require extra changes on EnumerableDefaults#nestedLoopJoin to avoid
returning duplicates for joinType SEMI)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
