hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r288784197
##########
File path: core/src/main/java/org/apache/calcite/rel/rules/FilterJoinRule.java
##########
@@ -116,6 +115,15 @@ protected FilterJoinRule(RelOptRuleOperand operand,
String id,
//~ Methods ----------------------------------------------------------------
+ /** Returns if it is needed to push the filter condition above join
+ * into the join condition.
+ */
+ private boolean needsPushInto(Join join) {
+ // If the join force the join info to be based on column equality,
+ // Or it is a non-correlated semijoin, returns false.
Review comment:
@danny0405 Can you update the comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
