hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve 
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r285291567
 
 

 ##########
 File path: 
core/src/main/java/org/apache/calcite/rel/metadata/RelMdExpressionLineage.java
 ##########
 @@ -258,11 +262,17 @@ protected RelMdExpressionLineage() {}
         }
         // Right input references might need to be updated if there are
         // table names clashes with left input
+        final RelDataType fullRowType = SqlValidatorUtil.createJoinType(
+            rexBuilder.getTypeFactory(),
+            rel.getLeft().getRowType(),
+            rel.getRight().getRowType(),
+            null,
+            ImmutableList.of());
 
 Review comment:
   Can you explain this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to