zabetak commented on a change in pull request #1246: [CALCITE-2968] New
AntiJoin relational expression
URL: https://github.com/apache/calcite/pull/1246#discussion_r291051071
##########
File path: core/src/main/java/org/apache/calcite/rel/core/JoinRelType.java
##########
@@ -152,7 +153,7 @@ public JoinRelType cancelNullsOnRight() {
}
/** Transform this JoinRelType to CorrelateJoinType. **/
- public CorrelateJoinType toLinq4j() {
+ public CorrelateJoinType toLinq4jCorrelateJoinType() {
Review comment:
I would consider JoinRelType (and all public methods) as part of our public
API. So we could say that this is a breaking change. On the other hand, I don't
expect this method to be used by the clients so I wouldn't put it here in the
first place. As far as I can see it is used only inside EnumerableCorrelate,
how about moving the code there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
