zabetak commented on a change in pull request #1246: [CALCITE-2968] New
AntiJoin relational expression
URL: https://github.com/apache/calcite/pull/1246#discussion_r291058383
##########
File path:
linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java
##########
@@ -1322,9 +1351,10 @@ private void closeInner() {
final Enumerable<TSource> outer, final Enumerable<TInner> inner,
final Predicate2<TSource, TInner> predicate,
Function2<TSource, TInner, TResult> resultSelector,
- final boolean generateNullsOnLeft,
- final boolean generateNullsOnRight) {
+ final JoinType joinType) {
Review comment:
I was thinking that EnumerableDefaults is an important API for Linq4j
project. For somebody who uses only this part of Calcite I would say that it is
part of the public API so this could be considered a breaking change. Since the
other reviewers (@julianhyde @danny0405 @hsyuan ) didn't bring this up I guess
I am overreacting so you can ignore my comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
